Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 17389003: interceptedNames should include all interceptor method generated, not just the ones called. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index b4f0d926ca3d6e79cb7f318682ace691f433e7e8..dd453556855be45cd81638abb77ca6ea5c7ca760 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -1550,12 +1550,6 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
return receiverType.refine(selector, compiler);
}
- void registerInvoke(HInvokeDynamic node, Selector selector) {
- if (node.isInterceptedCall) {
- backend.addInterceptedSelector(selector);
- }
- }
-
void registerMethodInvoke(HInvokeDynamic node) {
Selector selector = getOptimizedSelectorFor(node, node.selector);
@@ -1579,7 +1573,6 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
SourceString name = node.selector.name;
world.registerDynamicInvocation(name, selector);
}
- registerInvoke(node, selector);
}
void registerSetter(HInvokeDynamic node) {
@@ -1588,7 +1581,6 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
HType valueType = node.isInterceptedCall
? node.inputs[2].instructionType
: node.inputs[1].instructionType;
- registerInvoke(node, selector);
}
void registerGetter(HInvokeDynamic node) {
@@ -1596,7 +1588,6 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
world.registerDynamicGetter(selector.name, selector);
world.registerInstantiatedClass(
compiler.functionClass, work.resolutionTree);
- registerInvoke(node, selector);
}
visitInvokeDynamicSetter(HInvokeDynamicSetter node) {
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/tests/lib/mirrors/is_odd_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698