Ensure that there is no "hidden" DNS lookup in secure socket code

Ensure that there is no "hidden" DNS lookup in secure socket code

The required setting of the internet adddress of the peer for NSS is
now using the internet address which have already been looked up in
Dart code for normal secure socket connect.

In the cases where SecureSocket.secure and RawSecureSocket.secure is
used with a host name, the internet address of the already connected
socket will be used. If that is not sufficient an IntetnetAddress from
DNS lookup in Dart can be passed instead of just a host name.

R=ajohnsen@google.com, whesse@google.com
BUG=http://dartbug.com/11103

Committed: https://code.google.com/p/dart/source/detail?r=24174

[Søren Gjesse, 2013-06-19 07:42:11]

Working on Linux, testing on Windows and Mac OS

[Søren Gjesse, 2013-06-19 08:30:43]

Runs all standalone tests on Windows and Mac OS

[Anders Johnsen, 2013-06-19 08:44:53]

LGTM

https://codereview.chromium.org/17381012/diff/5001/runtime/bin/secure_socket.cc
File runtime/bin/secure_socket.cc (right):

https://codereview.chromium.org/17381012/diff/5001/runtime/bin/secure_socket....
runtime/bin/secure_socket.cc:597: ASSERT(sizeof(raw_addr->addr) <
sizeof(peername));
raw_addr->addr -> raw_addr->ss

or use

'static intptr_t SocketAddress::GetAddrLength(const RawAddr& addr)'

https://codereview.chromium.org/17381012/diff/5001/runtime/bin/secure_socket....
runtime/bin/secure_socket.cc:598: memmove(&peername, &raw_addr->addr,
sizeof(raw_addr->addr));
Ditto

[Bill Hesse, 2013-06-19 08:48:11]

LGTM.

[Søren Gjesse, 2013-06-19 09:06:53]

https://codereview.chromium.org/17381012/diff/5001/runtime/bin/secure_socket.cc
File runtime/bin/secure_socket.cc (right):

https://codereview.chromium.org/17381012/diff/5001/runtime/bin/secure_socket....
runtime/bin/secure_socket.cc:597: ASSERT(sizeof(raw_addr->addr) <
sizeof(peername));
On 2013/06/19 08:44:53, Anders Johnsen wrote:
> raw_addr->addr -> raw_addr->ss
> 
> or use
> 
> 'static intptr_t SocketAddress::GetAddrLength(const RawAddr& addr)'

Good Catch! Done.

https://codereview.chromium.org/17381012/diff/5001/runtime/bin/secure_socket....
runtime/bin/secure_socket.cc:598: memmove(&peername, &raw_addr->addr,
sizeof(raw_addr->addr));
On 2013/06/19 08:44:53, Anders Johnsen wrote:
> Ditto

Done.

[Søren Gjesse, 2013-06-19 09:07:53]

Committed patchset #4 manually as r24174 (presubmit successful).