runtime/bin/secure_socket_patch.dart - Issue 17381012: Ensure that there is no "hidden" DNS lookup in secure socket code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/secure_socket_patch.dart

Issue 17381012: Ensure that there is no "hidden" DNS lookup in secure socket code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/secure_socket_patch.dart

diff --git a/runtime/bin/secure_socket_patch.dart b/runtime/bin/secure_socket_patch.dart

index fdff0d517a7d80ca4f500d78b6ea87ae547c2110..58735f894b6db50751f3bf969c3c8bf6cf99eac3 100644

--- a/runtime/bin/secure_socket_patch.dart

+++ b/runtime/bin/secure_socket_patch.dart

@@ -57,6 +57,7 @@ class _SecureFilterImpl

}

void connect(String hostName,

+ Uint8List sockaddrStorage,

int port,

bool is_server,

String certificateName,

« no previous file with comments | « runtime/bin/secure_socket.cc ('k') | runtime/bin/socket_patch.dart » ('j') | no next file with comments »