Issue 17361004: Move FiftythreeBitOverflowError to VM-only patch file.

Issue 17361004: Move FiftythreeBitOverflowError to VM-only patch file. (Closed)

Created:
7 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 6 months ago

Reviewers:
zra, floitsch, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move FiftythreeBitOverflowError to VM-only patch file. The class is not meaningful in the core library, and should go away once dart2js has integers. R=floitsch@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24265

Patch Set 1 #

Total comments: 4

Patch Set 2 : Now 96% less visible! #

Patch Set 3 : Save ALL the files! #

Patch Set 4 : Made test detect error message too. #

Patch Set 5 : Adding rationale to error test. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -21 lines)			Patch
M	runtime/lib/errors_patch.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/errors.dart	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/standalone/53bit_overflow_test.dart	View	1 2 3 4	3 chunks	+16 lines, -13 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/17361004/diff/1/tests/standalone/53bit_overflow_test.dart File tests/standalone/53bit_overflow_test.dart (right): https://codereview.chromium.org/17361004/diff/1/tests/standalone/53bit_overflow_test.dart#newcode64 tests/standalone/53bit_overflow_test.dart:64: Expect.throws(double_to_int, (e) => e is Error); isn't the ...

7 years, 6 months ago (2013-06-20 14:48:27 UTC) #2

zra

https://codereview.chromium.org/17361004/diff/1/tests/standalone/53bit_overflow_test.dart File tests/standalone/53bit_overflow_test.dart (right): https://codereview.chromium.org/17361004/diff/1/tests/standalone/53bit_overflow_test.dart#newcode64 tests/standalone/53bit_overflow_test.dart:64: Expect.throws(double_to_int, (e) => e is Error); If the error ...

7 years, 6 months ago (2013-06-20 15:45:24 UTC) #3

srdjan

lgtm https://codereview.chromium.org/17361004/diff/1/tests/standalone/53bit_overflow_test.dart File tests/standalone/53bit_overflow_test.dart (right): https://codereview.chromium.org/17361004/diff/1/tests/standalone/53bit_overflow_test.dart#newcode64 tests/standalone/53bit_overflow_test.dart:64: Expect.throws(double_to_int, (e) => e is Error); On 2013/06/20 ...

7 years, 6 months ago (2013-06-20 16:06:08 UTC) #4

Lasse Reichstein Nielsen

7 years, 6 months ago (2013-06-21 05:41:49 UTC) #5

Lasse Reichstein Nielsen

The error is now private. We generally don't make anything visible that doesn't exist on ...

7 years, 6 months ago (2013-06-21 07:31:29 UTC) #6

Lasse Reichstein Nielsen

7 years, 6 months ago (2013-06-21 07:32:20 UTC) #7

Message was sent while issue was closed.

Committed patchset #5 manually as r24265 (presubmit successful).

Expand Messages | Collapse Messages