Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 17361003: Print out experimental test.py reproduction command (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Print out experimental test.py reproduction command R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=24231

Patch Set 1 #

Patch Set 2 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M tools/testing/dart/test_options.dart View 1 chunk +47 lines, -0 lines 4 comments Download
M tools/testing/dart/test_progress.dart View 1 chunk +9 lines, -0 lines 2 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/testing/dart/utils.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
@kasper: Just FYI.
7 years, 6 months ago (2013-06-20 13:38:34 UTC) #1
ricow1
LGTM https://codereview.chromium.org/17361003/diff/2001/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/17361003/diff/2001/tools/testing/dart/test_options.dart#newcode466 tools/testing/dart/test_options.dart:466: config['_reproducing_arguments_'] = why are you prefixing and postfixing ...
7 years, 6 months ago (2013-06-20 13:54:50 UTC) #2
kustermann
https://codereview.chromium.org/17361003/diff/2001/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/17361003/diff/2001/tools/testing/dart/test_options.dart#newcode466 tools/testing/dart/test_options.dart:466: config['_reproducing_arguments_'] = On 2013/06/20 13:54:50, ricow1 wrote: > why ...
7 years, 6 months ago (2013-06-20 14:17:24 UTC) #3
kustermann
7 years, 6 months ago (2013-06-20 14:19:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698