Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 17361003: Print out experimental test.py reproduction command (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 63c8164c0aac294189561dbb3a1693535163a17d..73c9cba04c25affcc6683ff3a7c55354d7866597 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -116,8 +116,9 @@ class Command {
executable = executable.replaceAll('/', '\\');
}
var quotedArguments = [];
- arguments.forEach((argument) => quotedArguments.add('"$argument"'));
- commandLine = "\"$executable\" ${quotedArguments.join(' ')}";
+ quotedArguments.add(escapeCommandLineArgument(executable));
+ quotedArguments.addAll(arguments.map(escapeCommandLineArgument));
+ commandLine = quotedArguments.join(' ');
}
String toString() => commandLine;

Powered by Google App Engine
This is Rietveld 408576698