Use identifiers in OperatingSystem.find.

Use identifiers in OperatingSystem.find.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/c6ea229ac9d1939876a90ab1458c301f8d789257

[kevmoo, 2016-02-24 23:54:59]

code LGTM, other than question below

What's the context for this change?

https://codereview.chromium.org/1732773003/diff/1/lib/src/backend/operating_s...
File lib/src/backend/operating_system.dart (right):

https://codereview.chromium.org/1732773003/diff/1/lib/src/backend/operating_s...
lib/src/backend/operating_system.dart:44: static OperatingSystem find(String
name) =>
Need to clarify name vs identifier in the arg, too?

[nweiz, 2016-02-25 23:44:34]

> What's the context for this change?

Semantically, the name is just human-readable whereas the identifier is what
machines should use to look up the value. Pragmatically, I need to use
OperatingSystem.find() to look up an OS based on a user-provided identifier.

https://codereview.chromium.org/1732773003/diff/1/lib/src/backend/operating_s...
File lib/src/backend/operating_system.dart (right):

https://codereview.chromium.org/1732773003/diff/1/lib/src/backend/operating_s...
lib/src/backend/operating_system.dart:44: static OperatingSystem find(String
name) =>
On 2016/02/24 23:54:59, kevmoo wrote:
> Need to clarify name vs identifier in the arg, too?

Done.

[nweiz, 2016-02-25 23:44:49]

Code review changes

[nweiz, 2016-02-25 23:44:53]

Description was changed from

==========
Use identifiers in OperatingSystem.find.

R=kevmoo@google.com
==========

to

==========
Use identifiers in OperatingSystem.find.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/test/commit/c6ea229ac9d1939876a90ab1458c301f8d78...
==========

[nweiz, 2016-02-25 23:44:55]

Committed patchset #2 (id:20001) manually as
c6ea229ac9d1939876a90ab1458c301f8d789257 (presubmit successful).