Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: test/runner/test_on_test.dart

Issue 1732773003: Use identifiers in OperatingSystem.find. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/plugin/platform_helpers.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/test_on_test.dart
diff --git a/test/runner/test_on_test.dart b/test/runner/test_on_test.dart
index 3fa8608def15f51da555a0b7e5be3d039bdf866a..c739bfe647626c590c7e68099ae50c7ce5bf44b1 100644
--- a/test/runner/test_on_test.dart
+++ b/test/runner/test_on_test.dart
@@ -34,7 +34,7 @@ void main() {
}, tags: 'content-shell');
test("runs a test suite on a matching operating system", () {
- _writeTestFile("os_test.dart", suiteTestOn: currentOS.name);
+ _writeTestFile("os_test.dart", suiteTestOn: currentOS.identifier);
var test = runTest(["os_test.dart"]);
test.stdout.expect(consumeThrough(contains("All tests passed!")));
@@ -42,7 +42,7 @@ void main() {
});
test("doesn't run a test suite on a non-matching operating system", () {
- _writeTestFile("os_test.dart", suiteTestOn: _otherOS,
+ _writeTestFile("os_test.dart", suiteTestOn: otherOS,
loadable: false);
var test = runTest(["os_test.dart"]);
@@ -54,9 +54,9 @@ void main() {
_writeTestFile("vm_test.dart", suiteTestOn: "vm");
_writeTestFile("browser_test.dart",
suiteTestOn: "browser", loadable: false);
- _writeTestFile("this_os_test.dart", suiteTestOn: currentOS.name);
+ _writeTestFile("this_os_test.dart", suiteTestOn: currentOS.identifier);
_writeTestFile("other_os_test.dart",
- suiteTestOn: _otherOS, loadable: false);
+ suiteTestOn: otherOS, loadable: false);
var test = runTest(["."]);
test.stdout.expect(consumeThrough(contains("+2: All tests passed!")));
« no previous file with comments | « lib/src/runner/plugin/platform_helpers.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698