Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730173004: Add on_os and on_platform fields. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add on_os and on_platform fields. These allow configuration based on the user's OS and the platform the test is running on. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/0329aeb5062165ec26340e0bc3688c3964971bd5

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 7

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -23 lines) Patch
M README.md View 1 chunk +5 lines, -0 lines 0 comments Download
M doc/package_config.md View 6 chunks +75 lines, -6 lines 0 comments Download
M lib/src/backend/metadata.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/backend/operating_system.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/runner/configuration.dart View 1 2 3 5 chunks +17 lines, -3 lines 0 comments Download
M lib/src/runner/configuration/load.dart View 1 3 chunks +26 lines, -2 lines 0 comments Download
M lib/src/runner/plugin/platform_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/utils.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/runner/configuration/configuration_test.dart View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A test/runner/configuration/platform_test.dart View 1 2 3 1 chunk +266 lines, -0 lines 0 comments Download
M test/runner/configuration/tags_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/test_on_test.dart View 1 2 3 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
4 years, 10 months ago (2016-02-26 00:00:46 UTC) #2
kevmoo
lgtm https://codereview.chromium.org/1730173004/diff/40001/lib/src/backend/operating_system.dart File lib/src/backend/operating_system.dart (right): https://codereview.chromium.org/1730173004/diff/40001/lib/src/backend/operating_system.dart#newcode45 lib/src/backend/operating_system.dart:45: all.firstWhere((platform) => platform.identifier == name, Rebase oops here ...
4 years, 10 months ago (2016-02-26 23:06:21 UTC) #3
nweiz
Code review changes
4 years, 9 months ago (2016-03-01 02:22:26 UTC) #4
nweiz
Committed patchset #4 (id:60001) manually as 0329aeb5062165ec26340e0bc3688c3964971bd5 (presubmit successful).
4 years, 9 months ago (2016-03-01 02:22:55 UTC) #6
nweiz
4 years, 9 months ago (2016-03-01 02:24:04 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1730173004/diff/40001/lib/src/runner/configur...
File lib/src/runner/configuration.dart (right):

https://codereview.chromium.org/1730173004/diff/40001/lib/src/runner/configur...
lib/src/runner/configuration.dart:13: import '../backend/operating_system.dart';
On 2016/02/26 23:06:20, kevmoo wrote:
> unused import?

Done.

https://codereview.chromium.org/1730173004/diff/40001/test/runner/configurati...
File test/runner/configuration/platform_test.dart (right):

https://codereview.chromium.org/1730173004/diff/40001/test/runner/configurati...
test/runner/configuration/platform_test.dart:10: import
'package:scheduled_test/scheduled_stream.dart';
On 2016/02/26 23:06:20, kevmoo wrote:
> unused import

Done.

https://codereview.chromium.org/1730173004/diff/40001/test/runner/test_on_tes...
File test/runner/test_on_test.dart (right):

https://codereview.chromium.org/1730173004/diff/40001/test/runner/test_on_tes...
test/runner/test_on_test.dart:7: import 'dart:io';
On 2016/02/26 23:06:21, kevmoo wrote:
> unused import

Done.

Powered by Google App Engine
This is Rietveld 408576698