Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: test/runner/configuration/configuration_test.dart

Issue 1730173004: Add on_os and on_platform fields. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/utils.dart ('k') | test/runner/configuration/platform_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/configuration/configuration_test.dart
diff --git a/test/runner/configuration/configuration_test.dart b/test/runner/configuration/configuration_test.dart
index 45e29af0884fde9e037041f6b8381c0075678e19..fa56479b6714b31ac1d81320807455ab6f9c94d8 100644
--- a/test/runner/configuration/configuration_test.dart
+++ b/test/runner/configuration/configuration_test.dart
@@ -263,5 +263,28 @@ void main() {
expect(merged.timeout, equals(new Timeout(new Duration(seconds: 2))));
});
});
+
+ group("for onPlatform", () {
+ test("merges each nested configuration", () {
+ var merged = new Configuration(
+ onPlatform: {
+ new PlatformSelector.parse("vm"): new Configuration(verboseTrace: true),
+ new PlatformSelector.parse("chrome"): new Configuration(jsTrace: true)
+ }
+ ).merge(new Configuration(
+ onPlatform: {
+ new PlatformSelector.parse("chrome"): new Configuration(jsTrace: false),
+ new PlatformSelector.parse("firefox"): new Configuration(skip: true)
+ }
+ ));
+
+ expect(merged.onPlatform[new PlatformSelector.parse("vm")].verboseTrace,
+ isTrue);
+ expect(merged.onPlatform[new PlatformSelector.parse("chrome")].jsTrace,
+ isFalse);
+ expect(merged.onPlatform[new PlatformSelector.parse("firefox")].skip,
+ isTrue);
+ });
+ });
});
}
« no previous file with comments | « lib/src/utils.dart ('k') | test/runner/configuration/platform_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698