Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1728943003: Fix TypedDataBuffer.insertAll() with an Iterable. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/typed_data@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix TypedDataBuffer.insertAll() with an Iterable. Closes #1. R=lrn@google.com Committed: https://github.com/dart-lang/typed_data/commit/4f952fba3d61b461d19521779650121673a50ca6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
M lib/typed_buffers.dart View 1 3 chunks +11 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/typed_buffers_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 10 months ago (2016-02-24 01:16:59 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1728943003/diff/1/lib/typed_buffers.dart File lib/typed_buffers.dart (right): https://codereview.chromium.org/1728943003/diff/1/lib/typed_buffers.dart#newcode263 lib/typed_buffers.dart:263: void _grow([int length]) { I would generally not ...
4 years, 10 months ago (2016-02-24 11:06:42 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2016-02-24 18:45:01 UTC) #3
nweiz
Committed patchset #2 (id:20001) manually as 4f952fba3d61b461d19521779650121673a50ca6 (presubmit successful).
4 years, 10 months ago (2016-02-24 18:45:14 UTC) #5
nweiz
4 years, 10 months ago (2016-02-24 18:45:56 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1728943003/diff/1/lib/typed_buffers.dart
File lib/typed_buffers.dart (right):

https://codereview.chromium.org/1728943003/diff/1/lib/typed_buffers.dart#newc...
lib/typed_buffers.dart:263: void _grow([int length]) {
On 2016/02/24 11:06:42, Lasse Reichstein Nielsen wrote:
> I would generally not make internal functions have optional parameters.
> Just make it non-optional, and always pass a value.
> That means changing the one other call (in `add`) to pass _length.

Done.

Powered by Google App Engine
This is Rietveld 408576698