Fix TypedDataBuffer.insertAll() with an Iterable.

lib/typed_buffers.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Growable typed-data lists.
 ///
 /// These lists works just as a typed-data list, except that they are growable.
 /// They use an underlying buffer, and when that buffer becomes too small, it
 /// is replaced by a new buffer.
 ///
@@ skipping 107 matching lines @@
     if (end == null && values is List) {
       end = values.length;
     }
     if (end != null) {
       _insertKnownLength(index, values, start, end);
       return;
     }
 
     // Add elements at end, growing as appropriate, then put them back at
     // position [index] using flip-by-double-reverse.
-    if (end != null) values = values.take(end);
-    int writeIndex = _length;
-    int skipCount = start;
+    var writeIndex = _length;
+    var skipCount = start;
     for (var value in values) {
       if (skipCount > 0) {
         skipCount--;
         continue;
       }
       if (writeIndex == _buffer.length) {
-        _grow();
+        _grow(writeIndex);
       }
       _buffer[writeIndex++] = value;
     }
+
     if (skipCount > 0) {
       throw new StateError("Too few elements");
     }
     if (end != null && writeIndex < end) {
       throw new RangeError.range(end, start, writeIndex, "end");
     }
+
     // Swap [index.._length) and [_length..writeIndex) by double-reversing.
     _reverse(_buffer, index, _length);
     _reverse(_buffer, _length, writeIndex);
     _reverse(_buffer, index, writeIndex);
     _length = writeIndex;
     return;
   }
 
   // Reverses the range [start..end) of buffer.
   static void _reverse(List<int> buffer, int start, int end) {
@@ skipping 91 matching lines @@
   List<E> _createBiggerBuffer(int requiredCapacity) {
     int newLength = _buffer.length * 2;
     if (requiredCapacity != null && newLength < requiredCapacity) {
       newLength = requiredCapacity;
     } else if (newLength < INITIAL_LENGTH) {
       newLength = INITIAL_LENGTH;
     }
     return _createBuffer(newLength);
   }
 
-  void _grow() {
-    _buffer = _createBiggerBuffer(null)..setRange(0, _length, _buffer);
+  /// Grows the buffer.
+  ///
+  /// This copies the first [length] elements into the new buffer. It defaults
+  /// to copying [_length] elements.
+  void _grow([int length]) {

[Lasse Reichstein Nielsen, 2016/02/24 11:06:42]

I would generally not make internal functions have optional parameters.
Just make it non-optional, and always pass a value.
That means changing the one other call (in `add`) to pass _length.

[nweiz, 2016/02/24 18:45:56]

Done.

+    _buffer = _createBiggerBuffer(null)
+      ..setRange(0, length ?? _length, _buffer);
   }
 
   void setRange(int start, int end, Iterable<E> source, [int skipCount = 0]) {
     if (end > _length) throw new RangeError.range(end, 0, _length);
     _setRange(start, end, source, skipCount);
   }
 
   /// Like [setRange], but with no bounds checking.
   void _setRange(int start, int end, Iterable<E> source, int skipCount) {
     if (source is _TypedDataBuffer<E>) {
@@ skipping 104 matching lines @@
   Int32x4 get _defaultValue => _zero;
   Int32x4List _createBuffer(int size) => new Int32x4List(size);
 }
 
 class Float32x4Buffer extends _TypedDataBuffer<Float32x4> {
   Float32x4Buffer([int initialLength = 0])
       : super(new Float32x4List(initialLength));
   Float32x4 get _defaultValue => new Float32x4.zero();
   Float32x4List _createBuffer(int size) => new Float32x4List(size);
 }