Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1717533002: Add new test configuration fields. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add new test configuration fields. These fields are only really useful when applied to particular tags, which we can now do. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/d7584085a76cbc162c36d5d9b1c0f7c2712ce4f9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -6 lines) Patch
M doc/package_config.md View 1 2 chunks +32 lines, -0 lines 0 comments Download
M lib/src/backend/platform_selector.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/runner/configuration.dart View 5 chunks +44 lines, -6 lines 0 comments Download
M lib/src/runner/configuration/load.dart View 3 chunks +15 lines, -0 lines 0 comments Download
M test/runner/configuration/configuration_test.dart View 10 chunks +47 lines, -0 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 10 months ago (2016-02-19 01:23:21 UTC) #1
kevmoo
LGTM might could move the existing skip to use this?
4 years, 10 months ago (2016-02-19 02:00:47 UTC) #2
nweiz
On 2016/02/19 02:00:47, kevmoo wrote: > LGTM > > might could move the existing skip ...
4 years, 10 months ago (2016-02-19 02:03:02 UTC) #3
nweiz
Committed patchset #2 (id:20001) manually as d7584085a76cbc162c36d5d9b1c0f7c2712ce4f9 (presubmit successful).
4 years, 10 months ago (2016-02-19 02:03:47 UTC) #5
kevmoo
4 years, 10 months ago (2016-02-19 02:03:49 UTC) #6
Message was sent while issue was closed.
On 2016/02/19 02:03:02, nweiz wrote:
> On 2016/02/19 02:00:47, kevmoo wrote:
> > LGTM
> > 
> > might could move the existing skip to use this?
> 
> Do you mean Metadata.skip? That's what this is using.

right...

Powered by Google App Engine
This is Rietveld 408576698