Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: lib/src/runner/configuration/load.dart

Issue 1717533002: Add new test configuration fields. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/configuration.dart ('k') | test/runner/configuration/configuration_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/configuration/load.dart
diff --git a/lib/src/runner/configuration/load.dart b/lib/src/runner/configuration/load.dart
index 147aca6c7d7f4df21b973ee1284eabbe86a31a44..f66f0fc4a6dcfc241707f34fdfd5df0cad38c987 100644
--- a/lib/src/runner/configuration/load.dart
+++ b/lib/src/runner/configuration/load.dart
@@ -10,6 +10,7 @@ import 'package:path/path.dart' as p;
import 'package:source_span/source_span.dart';
import 'package:yaml/yaml.dart';
+import '../../backend/platform_selector.dart';
import '../../backend/test_platform.dart';
import '../../frontend/timeout.dart';
import '../../utils.dart';
@@ -59,6 +60,17 @@ class _ConfigurationLoader {
var verboseTrace = _getBool("verbose_trace");
var jsTrace = _getBool("js_trace");
+ var skip = _getValue("skip", "boolean or string",
+ (value) => value is bool || value is String);
+ var skipReason;
+ if (skip is String) {
+ skipReason = skip;
+ skip = true;
+ }
+
+ var testOn = _parseValue("test_on",
+ (value) => new PlatformSelector.parse(value));
+
var timeout = _parseValue("timeout", (value) => new Timeout.parse(value));
var addTags = _getList("add_tags", (tagNode) {
@@ -79,6 +91,9 @@ class _ConfigurationLoader {
return new Configuration(
verboseTrace: verboseTrace,
jsTrace: jsTrace,
+ skip: skip,
+ skipReason: skipReason,
+ testOn: testOn,
timeout: timeout,
addTags: addTags,
tags: tags);
« no previous file with comments | « lib/src/runner/configuration.dart ('k') | test/runner/configuration/configuration_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698