Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1717483002: Make PlatformSelector use boolean_selector. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1378 lines) Patch
M README.md View 2 chunks +10 lines, -7 lines 0 comments Download
M lib/src/backend/metadata.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/platform_selector.dart View 2 chunks +33 lines, -65 lines 0 comments Download
D lib/src/backend/platform_selector/ast.dart View 1 chunk +0 lines, -137 lines 0 comments Download
D lib/src/backend/platform_selector/evaluator.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D lib/src/backend/platform_selector/parser.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D lib/src/backend/platform_selector/scanner.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D lib/src/backend/platform_selector/token.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D lib/src/backend/platform_selector/visitor.dart View 1 chunk +0 lines, -44 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -0 lines 0 comments Download
D test/backend/platform_selector/ast_test.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D test/backend/platform_selector/evaluate_test.dart View 1 chunk +0 lines, -142 lines 0 comments Download
D test/backend/platform_selector/parser_test.dart View 1 chunk +0 lines, -266 lines 0 comments Download
D test/backend/platform_selector/scanner_test.dart View 1 chunk +0 lines, -266 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 10 months ago (2016-02-18 22:47:25 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1717483002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1717483002/diff/1/pubspec.yaml#newcode40 pubspec.yaml:40: dependency_overrides: oops?
4 years, 10 months ago (2016-02-19 00:00:57 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2016-02-19 00:29:06 UTC) #3
nweiz
https://codereview.chromium.org/1717483002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1717483002/diff/1/pubspec.yaml#newcode40 pubspec.yaml:40: dependency_overrides: On 2016/02/19 00:00:57, kevmoo wrote: > oops? Done.
4 years, 10 months ago (2016-02-19 00:29:24 UTC) #4
nweiz
4 years, 10 months ago (2016-02-19 00:29:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6d60de76f4355de3d7963bafa71212b356e78070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698