Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: README.md

Issue 1717483002: Make PlatformSelector use boolean_selector. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/backend/metadata.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
diff --git a/README.md b/README.md
index 13381113a3f4ee36c5deb93c1852b91e4aafcfc8..6035cb91cb14a44d78e3b774731154ededbbe9a9 100644
--- a/README.md
+++ b/README.md
@@ -3,7 +3,7 @@
* [Writing Tests](#writing-tests)
* [Running Tests](#running-tests)
* [Restricting Tests to Certain Platforms](#restricting-tests-to-certain-platforms)
- * [Platform Selector Syntax](#platform-selector-syntax)
+ * [Platform Selectors](#platform-selectors)
* [Running Tests on Dartium](#running-tests-on-dartium)
* [Asynchronous Tests](#asynchronous-tests)
* [Running Tests With Custom HTML](#running-tests-with-custom-html)
@@ -176,13 +176,16 @@ specifies exactly which platforms a test can run on. It can be as simple as the
name of a platform, or a more complex Dart-like boolean expression involving
these platform names.
-### Platform Selector Syntax
+### Platform Selectors
-Platform selectors can contain identifiers, parentheses, and operators. When
-loading a test, each identifier is set to `true` or `false` based on the current
-platform, and the test is only loaded if the platform selector returns `true`.
-The operators `||`, `&&`, `!`, and `? :` all work just like they do in Dart. The
-valid identifiers are:
+Platform selectors use the [boolean selector syntax][] defined in the
+[`boolean_selector` package][boolean_selector], which is a subset of Dart's
+expression syntax that only supports boolean operations. The following
+identifiers are defined:
+
+[boolean selector syntax]: https://github.com/dart-lang/boolean_selector/blob/master/README.md
+
+[boolean_selector]: https://pub.dartlang.org/packages/boolean_selector
* `vm`: Whether the test is running on the command-line Dart VM.
« no previous file with comments | « no previous file | lib/src/backend/metadata.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698