Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1715523003: Warn when an unsupported platform is passed. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Warn when an unsupported platform is passed. If the config file contains a top-level test_on field, the runner will now warn if the runner is invoked with an unsupported platform. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/bfc313427dd46417ca5fad5a1adee228383ec42f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -46 lines) Patch
M README.md View 1 chunk +5 lines, -0 lines 0 comments Download
M doc/package_config.md View 2 chunks +14 lines, -4 lines 0 comments Download
M lib/src/backend/operating_system.dart View 2 chunks +10 lines, -7 lines 2 comments Download
M lib/src/backend/platform_selector.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner.dart View 3 chunks +52 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/io.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 2 chunks +96 lines, -27 lines 0 comments Download
M test/runner/test_on_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 10 months ago (2016-02-19 02:04:45 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1715523003/diff/1/lib/src/backend/operating_system.dart File lib/src/backend/operating_system.dart (right): https://codereview.chromium.org/1715523003/diff/1/lib/src/backend/operating_system.dart#newcode15 lib/src/backend/operating_system.dart:15: static const macOS = const OperatingSystem._("OS X", "mac-os"); ...
4 years, 10 months ago (2016-02-19 02:08:47 UTC) #2
nweiz
https://codereview.chromium.org/1715523003/diff/1/lib/src/backend/operating_system.dart File lib/src/backend/operating_system.dart (right): https://codereview.chromium.org/1715523003/diff/1/lib/src/backend/operating_system.dart#newcode15 lib/src/backend/operating_system.dart:15: static const macOS = const OperatingSystem._("OS X", "mac-os"); On ...
4 years, 10 months ago (2016-02-23 22:02:38 UTC) #3
nweiz
4 years, 10 months ago (2016-02-23 22:02:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bfc313427dd46417ca5fad5a1adee228383ec42f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698