Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: lib/src/backend/platform_selector.dart

Issue 1715523003: Warn when an unsupported platform is passed. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/backend/platform_selector.dart
diff --git a/lib/src/backend/platform_selector.dart b/lib/src/backend/platform_selector.dart
index af55257b25ddfeb8a1f584b2782591e57e17ef11..10969f756a69407fa45d392e9e8aff5871c01595 100644
--- a/lib/src/backend/platform_selector.dart
+++ b/lib/src/backend/platform_selector.dart
@@ -12,7 +12,7 @@ import 'test_platform.dart';
final _validVariables =
new Set<String>.from(["posix", "dart-vm", "browser", "js", "blink"])
..addAll(TestPlatform.all.map((platform) => platform.identifier))
- ..addAll(OperatingSystem.all.map((os) => os.name));
+ ..addAll(OperatingSystem.all.map((os) => os.identifier));
/// An expression for selecting certain platforms, including operating systems
/// and browsers.
@@ -46,7 +46,7 @@ class PlatformSelector {
return _inner.evaluate((variable) {
if (variable == platform.identifier) return true;
- if (variable == os.name) return true;
+ if (variable == os.identifier) return true;
switch (variable) {
case "dart-vm": return platform.isDartVM;
case "browser": return platform.isBrowser;

Powered by Google App Engine
This is Rietveld 408576698