Issue 171513008: Don't close "pub serve" before we've read its output in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171513008: Don't close "pub serve" before we've read its output in tests. (Closed)

Created:
6 years, 10 months ago by nweiz

Modified:
6 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't close "pub serve" before we've read its output in tests. I was unable to reproduce the bug in question, but it seems likely that this will fix it. R=rnystrom@google.com BUG=16892 Committed: https://code.google.com/p/dart/source/detail?r=32839

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	sdk/lib/_internal/pub/pub.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

6 years, 10 months ago (2014-02-20 01:29:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32839 (presubmit successful).