Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart

Issue 171513008: Don't close "pub serve" before we've read its output in tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/pub.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart
diff --git a/sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart b/sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart
index 2f0cfe63a59812d1f644772a59f7a13a204aae28..05f99335d8e4e6b89f279cee3c7720d580b5d75c 100644
--- a/sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart
+++ b/sdk/lib/_internal/pub/test/serve/warns_on_assets_paths_test.dart
@@ -35,10 +35,10 @@ main() {
var pub = pubServe();
waitForBuildSuccess();
- endPubServe();
var assetsPath = path.join('web', 'assets');
pub.stderr.expect(consumeThrough(matches(getWarningRegExp(assetsPath))));
+ endPubServe();
});
integration('warns user about assets dir nested anywhere in "web"', () {
@@ -54,10 +54,10 @@ main() {
var pub = pubServe();
waitForBuildSuccess();
- endPubServe();
var assetsPath = path.join('web', 'foo', 'assets');
pub.stderr.expect(consumeThrough(matches(getWarningRegExp(assetsPath))));
+ endPubServe();
});
integration('warns user about assets file in the root of "web"', () {
@@ -71,10 +71,10 @@ main() {
var pub = pubServe();
waitForBuildSuccess();
- endPubServe();
var assetsPath = path.join('web', 'assets');
pub.stderr.expect(consumeThrough(matches(getWarningRegExp(assetsPath))));
+ endPubServe();
});
integration('warns user about assets file nested anywhere in "web"', () {
@@ -90,10 +90,10 @@ main() {
var pub = pubServe();
waitForBuildSuccess();
- endPubServe();
var assetsPath = path.join('web', 'foo', 'assets');
pub.stderr.expect(consumeThrough(matches(getWarningRegExp(assetsPath))));
+ endPubServe();
});
integration('does not warn if no assets dir or file anywhere in "web"', () {
« no previous file with comments | « sdk/lib/_internal/pub/pub.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698