Issue 17131002: Enables language tests for SIMMIPS.

Issue 17131002: Enables language tests for SIMMIPS. (Closed)

Created:
7 years, 6 months ago by zra

Modified:
7 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enables language tests for SIMMIPS. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24098

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1015 lines, -240 lines)			Patch
M	runtime/vm/assembler_mips.h	View	1	4 chunks	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_patcher_mips.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/constants_mips.h	View		2 chunks	+5 lines, -8 lines	0 comments	Download
M	runtime/vm/debugger_mips.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_mips.cc	View		2 chunks	+16 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1	25 chunks	+211 lines, -39 lines	0 comments	Download
M	runtime/vm/instructions_mips.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/instructions_mips.cc	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		29 chunks	+416 lines, -59 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View		12 chunks	+28 lines, -33 lines	0 comments	Download
M	runtime/vm/runtime_entry_mips.cc	View		1 chunk	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/simulator_mips.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1	13 chunks	+87 lines, -7 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		35 chunks	+164 lines, -75 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

This CL mimics the changes on ARM to get the same tests going. I also ...

7 years, 6 months ago (2013-06-15 00:45:54 UTC) #1

regis

LGTM https://codereview.chromium.org/17131002/diff/1/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/17131002/diff/1/runtime/vm/assembler_mips.h#newcode71 runtime/vm/assembler_mips.h:71: int32_t get_offset() const { return offset_; } We ...

7 years, 6 months ago (2013-06-15 09:52:48 UTC) #2

zra

Thanks! https://codereview.chromium.org/17131002/diff/1/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/17131002/diff/1/runtime/vm/assembler_mips.h#newcode71 runtime/vm/assembler_mips.h:71: int32_t get_offset() const { return offset_; } On ...

7 years, 6 months ago (2013-06-17 15:58:15 UTC) #3

zra

7 years, 6 months ago (2013-06-17 15:58:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24098 (presubmit successful).

Expand Messages | Collapse Messages