Load web tests using the plugin infrastructure.

Load web tests using the plugin infrastructure.

Also, we now determine whether the user is debugging a given browser in
BrowserManager rather than individual suites.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/dc2fbc50c04ca7f593290a2a4a43f227dba4847a

[kevmoo, 2016-02-17 16:22:48]

lgtm

https://codereview.chromium.org/1704773002/diff/1/lib/src/runner/browser/brow...
File lib/src/runner/browser/browser_manager.dart (right):

https://codereview.chromium.org/1704773002/diff/1/lib/src/runner/browser/brow...
lib/src/runner/browser/browser_manager.dart:155: _timer = new
RestartableTimer(new Duration(seconds: 3), () {
const Duration?

https://codereview.chromium.org/1704773002/diff/1/lib/src/runner/browser/stat...
File lib/src/runner/browser/static/host.dart (right):

https://codereview.chromium.org/1704773002/diff/1/lib/src/runner/browser/stat...
lib/src/runner/browser/static/host.dart:93: new Timer.periodic(new
Duration(seconds: 1),
const Duration?

[nweiz, 2016-02-17 21:52:04]

https://codereview.chromium.org/1704773002/diff/1/lib/src/runner/browser/brow...
File lib/src/runner/browser/browser_manager.dart (right):

https://codereview.chromium.org/1704773002/diff/1/lib/src/runner/browser/brow...
lib/src/runner/browser/browser_manager.dart:155: _timer = new
RestartableTimer(new Duration(seconds: 3), () {
On 2016/02/17 16:22:48, kevmoo wrote:
> const Duration?

I really don't think const adds any value in most cases. I haven't seen any
evidence that it's faster—and in fact, I think it's often slower in dart2js
because of the overhead of ensuring instance identity. 

In fact, going forward, I don't intend to use const at all unless one of the
following is true:

* I'm using the immutability of a const collection.

* I'm writing an enum.

* A field is likely to be used in an annotation or other situation in which
constness is required.

[nweiz, 2016-02-17 21:53:05]

Description was changed from

==========
Load web tests using the plugin infrastructure.

Also, we now determine whether the user is debugging a given browser in
BrowserManager rather than individual suites.

R=kevmoo@google.com
==========

to

==========
Load web tests using the plugin infrastructure.

Also, we now determine whether the user is debugging a given browser in
BrowserManager rather than individual suites.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/test/commit/dc2fbc50c04ca7f593290a2a4a43f227dba4...
==========

[nweiz, 2016-02-17 21:53:06]

Committed patchset #1 (id:1) manually as
dc2fbc50c04ca7f593290a2a4a43f227dba4847a (presubmit successful).