Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: lib/pub_serve.dart

Issue 1704773002: Load web tests using the plugin infrastructure. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/runner.dart » ('j') | lib/src/runner/browser/browser_manager.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/pub_serve.dart
diff --git a/lib/pub_serve.dart b/lib/pub_serve.dart
index f1fa8c7bde9ef8d2f45fea38f0a29313631a075e..8951fd427b902f64557a8382ab38bc786e3a2e58 100644
--- a/lib/pub_serve.dart
+++ b/lib/pub_serve.dart
@@ -49,14 +49,18 @@ class PubServeTransformer extends Transformer implements DeclaringTransformer {
transform.addOutput(
new Asset.fromString(id.addExtension('.browser_test.dart'), '''
-import "package:test/src/runner/browser/iframe_listener.dart";
+ import "package:stream_channel/stream_channel.dart";
-import "${p.url.basename(id.path)}" as test;
+ import "package:test/src/runner/plugin/remote_platform_helpers.dart";
+ import "package:test/src/runner/browser/post_message_channel.dart";
-void main() {
- IframeListener.start(() => test.main);
-}
-'''));
+ import "${p.url.basename(id.path)}" as test;
+
+ void main() {
+ var channel = serializeSuite(() => test.main);
+ postMessageChannel().pipe(channel);
+ }
+ '''));
// If the user has their own HTML file for the test, let that take
// precedence. Otherwise, create our own basic file.
@@ -65,14 +69,15 @@ void main() {
transform.addOutput(
new Asset.fromString(htmlId, '''
-<!DOCTYPE html>
-<html>
-<head>
- <title>${HTML_ESCAPE.convert(id.path)} Test</title>
- <link rel="x-dart-test" href="${HTML_ESCAPE.convert(p.url.basename(id.path))}">
- <script src="packages/test/dart.js"></script>
-</head>
-</html>
-'''));
+ <!DOCTYPE html>
+ <html>
+ <head>
+ <title>${HTML_ESCAPE.convert(id.path)} Test</title>
+ <link rel="x-dart-test"
+ href="${HTML_ESCAPE.convert(p.url.basename(id.path))}">
+ <script src="packages/test/dart.js"></script>
+ </head>
+ </html>
+ '''));
}
}
« no previous file with comments | « no previous file | lib/src/runner.dart » ('j') | lib/src/runner/browser/browser_manager.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698