Issue 16951018: Fix left shift with constant on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16951018: Fix left shift with constant on ARM. (Closed)

Created:
7 years, 6 months ago by regis

Modified:
7 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix left shift with constant on ARM. Implement float array store on ARM. Update status files. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=24033

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -24 lines)			Patch
M	runtime/vm/intermediate_language_arm.cc	View		6 chunks	+34 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/16951018/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/16951018/diff/1/tests/standalone/standalone.status#newcode166 tests/standalone/standalone.status:166: io/file_system_links_test: Crash # Issue: 11207 Are these io/ ...

7 years, 6 months ago (2013-06-14 16:03:55 UTC) #2

regis

Thanks https://codereview.chromium.org/16951018/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/16951018/diff/1/tests/standalone/standalone.status#newcode166 tests/standalone/standalone.status:166: io/file_system_links_test: Crash # Issue: 11207 On 2013/06/14 16:03:55, ...

7 years, 6 months ago (2013-06-14 16:21:16 UTC) #3

regis

7 years, 6 months ago (2013-06-14 16:22:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24033 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16951018: Fix left shift with constant on ARM. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages