Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 16929007: - Do NOT mix malloc/free and new/delete! (Closed)

Created:
7 years, 6 months ago by Ivan Posva
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -13 lines) Patch
M runtime/bin/directory.h View 1 chunk +1 line, -9 lines 0 comments Download
M runtime/bin/directory_android.cc View 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/directory_linux.cc View 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/directory_macos.cc View 2 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/directory_win.cc View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
7 years, 6 months ago (2013-06-18 00:52:28 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 6 months ago (2013-06-18 00:57:08 UTC) #2
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-18 05:53:52 UTC) #3
Ivan Posva
7 years, 6 months ago (2013-06-18 15:44:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r24145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698