Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: runtime/bin/directory_linux.cc

Issue 16929007: - Do NOT mix malloc/free and new/delete! (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory_android.cc ('k') | runtime/bin/directory_macos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory_linux.cc
===================================================================
--- runtime/bin/directory_linux.cc (revision 24116)
+++ runtime/bin/directory_linux.cc (working copy)
@@ -23,7 +23,7 @@
PathBuffer::PathBuffer() : length_(0) {
- data_ = new char[PATH_MAX + 1];
+ data_ = calloc(PATH_MAX + 1, sizeof(char)); // NOLINT
}
bool PathBuffer::AddW(const wchar_t* name) {
@@ -195,6 +195,17 @@
}
+void DirectoryListingEntry::ResetLink() {
+ if (link_ != NULL && (parent_ == NULL || parent_->link_ != link_)) {
+ delete link_;
+ link_ = NULL;
+ }
+ if (parent_ != NULL) {
+ link_ = parent_->link_;
+ }
+}
+
+
static bool DeleteRecursively(PathBuffer* path);
« no previous file with comments | « runtime/bin/directory_android.cc ('k') | runtime/bin/directory_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698