Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 16737003: Break a cycle in the speculative type propagator by checking if a desired type goes to unknown. (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Break a cycle in the speculative type propagator by checking if a desired type goes to unknown. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart View 3 chunks +11 lines, -2 lines 0 comments Download
A tests/language/type_propagation2_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-10 11:56:00 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-06-10 12:02:09 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-10 12:27:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698