Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: tests/language/type_propagation2_test.dart

Issue 16737003: Break a cycle in the speculative type propagator by checking if a desired type goes to unknown. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/type_propagation2_test.dart
===================================================================
--- tests/language/type_propagation2_test.dart (revision 0)
+++ tests/language/type_propagation2_test.dart (revision 0)
@@ -0,0 +1,24 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Regression test for dart2js that used to infinite loop on
+// speculatively propagating types.
+
+class Bar {
+ noSuchMethod(e) => null;
+}
+
+main() {
+ var d = new Bar();
+
+ while (false) {
+ // [input] will change from indexable to unknown: the use line 20
+ // changes its decision because [a2] changes its type from unknown to
+ // null.
+ var input = ((x) {})(null);
+ var p2 = input.keys.firstWhere(null);
+ var a2 = input.keys.firstWhere(null);
+ print(input[a2] == p2);
+ }
+}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698