Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1668983003: Support the new isolate load error messages. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support the new isolate load error messages. Closes #1387 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/5738fb4592c96ffb0439e92ae8b823ccdc0a6623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M lib/src/barback/transformer_isolate.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_with_an_import_error_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 10 months ago (2016-02-04 22:52:24 UTC) #1
Bob Nystrom
lgtm
4 years, 10 months ago (2016-02-05 17:59:53 UTC) #2
nweiz
4 years, 10 months ago (2016-02-05 19:19:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5738fb4592c96ffb0439e92ae8b823ccdc0a6623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698