Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: lib/src/barback/transformer_isolate.dart

Issue 1668983003: Support the new isolate load error messages. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/transformer/fails_to_load_a_transform_with_an_import_error_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/transformer_isolate.dart
diff --git a/lib/src/barback/transformer_isolate.dart b/lib/src/barback/transformer_isolate.dart
index e833be0ae11a38ccc11fe388da7aee7b634b3c9d..ae025c800b488960aaa116c576055c916a6a0743 100644
--- a/lib/src/barback/transformer_isolate.dart
+++ b/lib/src/barback/transformer_isolate.dart
@@ -91,9 +91,7 @@ class TransformerIsolate {
// "package:" URI, so we have to be liberal in what we look for in the
// error message.
var missingTransformer = idsToUrls.keys.firstWhere((id) =>
- firstErrorLine.startsWith(
- "Load Error for") &&
- firstErrorLine.contains(idsToUrls[id].path),
+ firstErrorLine.startsWith('Could not import "${idsToUrls[id]}"'),
orElse: () => throw error);
var packageUri = idToPackageUri(idsToAssetIds[missingTransformer]);
« no previous file with comments | « no previous file | test/transformer/fails_to_load_a_transform_with_an_import_error_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698