Add configuration support for choosing test paths.

Add configuration support for choosing test paths.

This adds two fields: "paths" allows users to specify the paths that are
used if nothing is passed on the command line, and "filename" allows
users to declare which individual files should be loaded.

I'm closing out the package-level config file issue because this is the
last non-plugin feature mentioned in it. There's still a lot more work
to do, but that's tracked in separate issues.

Closes #46

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/d31e2c5c3f884abb94c53c1db004926a2c708965

[kevmoo, 2016-02-04 17:50:05]

lgtm

https://codereview.chromium.org/1668573003/diff/1/doc/package_config.md
File doc/package_config.md (right):

https://codereview.chromium.org/1668573003/diff/1/doc/package_config.md#newco...
doc/package_config.md:30: Paths must be relative, and they must be in URL format
so that they're
URL format meaning...forward slashes?

https://codereview.chromium.org/1668573003/diff/1/lib/src/runner/configuratio...
File lib/src/runner/configuration.dart (right):

https://codereview.chromium.org/1668573003/diff/1/lib/src/runner/configuratio...
lib/src/runner/configuration.dart:145: _filename = filename,
Set the final field here instead of doing the null check + create new Glob in
every getter access?

[nweiz, 2016-02-04 20:06:47]

https://codereview.chromium.org/1668573003/diff/1/doc/package_config.md
File doc/package_config.md (right):

https://codereview.chromium.org/1668573003/diff/1/doc/package_config.md#newco...
doc/package_config.md:30: Paths must be relative, and they must be in URL format
so that they're
On 2016/02/04 17:50:05, kevmoo wrote:
> URL format meaning...forward slashes?

That's the most obvious thing, but it also means that URL-encoding will be
respected and certain characters are disallowed. For example, "[foo]" is a valid
Posix path but not a valid URL.

https://codereview.chromium.org/1668573003/diff/1/lib/src/runner/configuratio...
File lib/src/runner/configuration.dart (right):

https://codereview.chromium.org/1668573003/diff/1/lib/src/runner/configuratio...
lib/src/runner/configuration.dart:145: _filename = filename,
On 2016/02/04 17:50:05, kevmoo wrote:
> Set the final field here instead of doing the null check + create new Glob in
> every getter access?

It's important to be able to differentiate between "the user hasn't set a
filename" and "the user has set a filename that happens to be the default". The
glob constructor is expensive, though, so I'll cache the default value.

[nweiz, 2016-02-04 20:09:22]

Description was changed from

==========
Add configuration support for choosing test paths.

This adds two fields: "paths" allows users to specify the paths that are
used if nothing is passed on the command line, and "filename" allows
users to declare which individual files should be loaded.

I'm closing out the package-level config file issue because this is the
last non-plugin feature mentioned in it. There's still a lot more work
to do, but that's tracked in separate issues.

Closes #46

R=kevmoo@google.com
==========

to

==========
Add configuration support for choosing test paths.

This adds two fields: "paths" allows users to specify the paths that are
used if nothing is passed on the command line, and "filename" allows
users to declare which individual files should be loaded.

I'm closing out the package-level config file issue because this is the
last non-plugin feature mentioned in it. There's still a lot more work
to do, but that's tracked in separate issues.

Closes #46

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/test/commit/d31e2c5c3f884abb94c53c1db004926a2c70...
==========

[nweiz, 2016-02-04 20:09:24]

Committed patchset #2 (id:20001) manually as
d31e2c5c3f884abb94c53c1db004926a2c708965 (presubmit successful).