Add configuration support for choosing test paths.

lib/src/runner/configuration.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
 
+import 'package:glob/glob.dart';
 import 'package:path/path.dart' as p;
 
 import '../frontend/timeout.dart';
 import '../backend/metadata.dart';
 import '../backend/test_platform.dart';
 import '../util/io.dart';
 import 'configuration/args.dart' as args;
 import 'configuration/load.dart';
 import 'configuration/values.dart';
 
@@ skipping 51 matching lines @@
       pauseAfterLoad ? 1 : (_concurrency ?? defaultConcurrency);
   final int _concurrency;
 
   /// The paths from which to load tests.
   List<String> get paths => _paths ?? ["test"];
   final List<String> _paths;
 
   /// Whether the load paths were passed explicitly or the default was used.
   bool get explicitPaths => _paths != null;
 
+  /// The glob matching the basename of tests to run.
+  ///
+  /// This is used to find tests within a directory.
+  Glob get filename => _filename ?? new Glob("*_test.dart");
+  final Glob _filename;
+
   /// The pattern to match against test names to decide which to run, or `null`
   /// if all tests should be run.
   final Pattern pattern;
 
   /// The set of platforms on which to run tests.
   List<TestPlatform> get platforms => _platforms ?? [TestPlatform.vm];
   final List<TestPlatform> _platforms;
 
   /// Restricts the set of tests to a set of tags.
   ///
@@ skipping 22 matching lines @@
   /// Loads the configuration from [path].
   ///
   /// Throws an [IOException] if [path] does not exist or cannot be read. Throws
   /// a [FormatException] if its contents are invalid.
   factory Configuration.load(String path) => load(path);
 
   Configuration({bool help, bool version, bool verboseTrace, bool jsTrace,
           bool pauseAfterLoad, bool color, String packageRoot, String reporter,
           int pubServePort, int concurrency, Timeout timeout, this.pattern,
           Iterable<TestPlatform> platforms, Iterable<String> paths,
-          Iterable<String> tags, Iterable<String> excludeTags})
+          Glob filename, Iterable<String> tags, Iterable<String> excludeTags})
       : _help = help,
         _version = version,
         _verboseTrace = verboseTrace,
         _jsTrace = jsTrace,
         _pauseAfterLoad = pauseAfterLoad,
         _color = color,
         _packageRoot = packageRoot,
         _reporter = reporter,
         pubServeUrl = pubServePort == null
             ? null
             : Uri.parse("http://localhost:$pubServePort"),
         _concurrency = concurrency,
         timeout = (pauseAfterLoad ?? false)
             ? Timeout.none
             : (timeout == null ? new Timeout.factor(1) : timeout),
         _platforms = _list(platforms),
         _paths = _list(paths),
+        _filename = filename,

[kevmoo, 2016/02/04 17:50:05]

Set the final field here instead of doing the null check + create new Glob in
every getter access?

[nweiz, 2016/02/04 20:06:47]

It's important to be able to differentiate between "the user hasn't set a
filename" and "the user has set a filename that happens to be the default". The
glob constructor is expensive, though, so I'll cache the default value.

         tags = tags?.toSet() ?? new Set(),
-        excludeTags = excludeTags?.toSet() ?? new Set();
+        excludeTags = excludeTags?.toSet() ?? new Set() {
+    if (_filename != null && _filename.context.style != p.style) {
+      throw new ArgumentError(
+          "filename's context must match the current operating system, was "
+              "${_filename.context.style}.");
+    }
+  }
 
   /// Returns a [input] as a list or `null`.
   ///
   /// If [input] is `null` or empty, this returns `null`. Otherwise, it returns
   /// `input.toList()`.
   static List _list(Iterable input) {
     if (input == null) return null;
     input = input.toList();
     if (input.isEmpty) return null;
     return input;
@@ skipping 12 matching lines @@
       pauseAfterLoad: other._pauseAfterLoad ?? _pauseAfterLoad,
       color: other._color ?? _color,
       packageRoot: other._packageRoot ?? _packageRoot,
       reporter: other._reporter ?? _reporter,
       pubServePort: (other.pubServeUrl ?? pubServeUrl)?.port,
       concurrency: other._concurrency ?? _concurrency,
       timeout: timeout.merge(other.timeout),
       pattern: other.pattern ?? pattern,
       platforms: other._platforms ?? _platforms,
       paths: other._paths ?? _paths,
+      filename: other._filename ?? _filename,
       tags: other.tags.union(tags),
       excludeTags: other.excludeTags.union(excludeTags));
 }