Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 165773002: Remove ObjectMirror.[]. (Closed)

Created:
6 years, 10 months ago by rmacnak
Modified:
6 years, 9 months ago
Reviewers:
ahe, gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -254 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 2 5 chunks +0 lines, -57 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 2 7 chunks +0 lines, -20 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 2 3 chunks +0 lines, -68 lines 0 comments Download
M tests/lib/lib.status View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D tests/lib/mirrors/invoke_subscript_test.dart View 1 chunk +0 lines, -107 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
6 years, 10 months ago (2014-02-14 02:39:52 UTC) #1
gbracha
lgtm
6 years, 10 months ago (2014-02-14 18:47:01 UTC) #2
ahe
lgtm
6 years, 10 months ago (2014-02-14 18:47:55 UTC) #3
rmacnak
6 years, 9 months ago (2014-03-11 18:21:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r33543 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698