Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 165773002: Remove ObjectMirror.[]. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: sync Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | sdk/lib/mirrors/mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart
index 2668424db6b43939be34061a4f77b6ade67bc6f8..687699314ea6d66de5ee861b97af6c0a02bd3fb4 100644
--- a/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/lib/js_mirrors.dart
@@ -485,10 +485,6 @@ class JsLibraryMirror extends JsDeclarationMirror with JsObjectMirror
// TODO(ahe): Test this getter.
DeclarationMirror get owner => null;
- // TODO(ahe): Implement this.
- Function operator [](Symbol name)
- => throw new UnimplementedError();
-
List<LibraryDependencyMirror> get libraryDependencies
=> throw new UnimplementedError();
}
@@ -791,9 +787,6 @@ class JsMixinApplication extends JsTypeMirror with JsObjectMirror
List<TypeMirror> get typeArguments => const <TypeMirror>[];
- // TODO(ahe): Implement this.
- Function operator [](Symbol name) => throw new UnimplementedError();
-
bool get isAbstract => throw new UnimplementedError();
bool isSubclassOf(ClassMirror other) {
@@ -1103,9 +1096,6 @@ class JsInstanceMirror extends JsObjectMirror implements InstanceMirror {
// TODO(ahe): Remove this method from the API.
MirrorSystem get mirrors => currentJsMirrorSystem;
-
- // TODO(ahe): Implement this method.
- Function operator [](Symbol name) => throw new UnimplementedError();
}
/**
@@ -1403,9 +1393,6 @@ class JsTypeBoundClassMirror extends JsDeclarationMirror
// TODO(ahe): Implement this.
ClassMirror get mixin => throw new UnimplementedError();
- // TODO(ahe): Implement this.
- Function operator [](Symbol name) => throw new UnimplementedError();
-
bool isSubtypeOf(TypeMirror other) => throw new UnimplementedError();
bool isAssignableTo(TypeMirror other) => throw new UnimplementedError();
@@ -1915,9 +1902,6 @@ class JsClassMirror extends JsTypeMirror with JsObjectMirror
// TODO(ahe): Implement this.
ClassMirror get mixin => throw new UnimplementedError();
- // TODO(ahe): Implement this.
- Function operator [](Symbol name) => throw new UnimplementedError();
-
bool get isAbstract => throw new UnimplementedError();
bool isSubclassOf(ClassMirror other) {
@@ -2109,9 +2093,6 @@ function(reflectee) {
InstanceMirror findInContext(Symbol name, {ifAbsent: null}) {
throw new UnsupportedError("ClosureMirror.findInContext not yet supported");
}
-
- // TODO(ahe): Implement this method.
- Function operator [](Symbol name) => throw new UnimplementedError();
}
class JsMethodMirror extends JsDeclarationMirror implements MethodMirror {
@@ -2412,7 +2393,6 @@ class BrokenClassMirror {
Symbol constructorName,
List positionalArguments,
[Map<Symbol, dynamic> namedArguments]) => throw new UnimplementedError();
- Function operator [](Symbol name) => throw new UnimplementedError();
InstanceMirror invoke(Symbol memberName,
List positionalArguments,
[Map<Symbol, dynamic> namedArguments])
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | sdk/lib/mirrors/mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698