Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 16533002: Fix 2/2 for bug https://code.google.com/p/dart/issues/detail?id=11117: when inlining a generative c… (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix 2/2 for bug https://code.google.com/p/dart/issues/detail?id=11117: when inlining a generative constructor, register it to the backend. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23666

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
A tests/language/inferrer_constructor2_test.dart View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-06 08:26:00 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-06-06 08:29:39 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-06 08:58:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r23666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698