Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: tests/language/inferrer_constructor2_test.dart

Issue 16533002: Fix 2/2 for bug https://code.google.com/p/dart/issues/detail?id=11117: when inlining a generative c… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/inferrer_constructor2_test.dart
===================================================================
--- tests/language/inferrer_constructor2_test.dart (revision 0)
+++ tests/language/inferrer_constructor2_test.dart (revision 0)
@@ -0,0 +1,62 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Regression test for dart2js that used to optimistically infer the
+// wrong types for fields because of generative constructors being
+// inlined.
+
+import "package:expect/expect.dart";
+import "compiler_annotations.dart";
+
+class A {
+ var foo;
+ var bar;
+
+ @DontInline
+ A() {
+ // Currently defeat inlining by using a closure.
+ bar = () => 42;
+ foo = 54;
+ }
+ A.inline();
+}
+
+main() {
+ // Make sure A's constructor is analyzed first by surrounding the
+ // body by two allocations.
+ new A();
+ bar();
+ new A();
+}
+
+class B {
+ var bar;
+ var closure;
+ @DontInline
+ B() {
+ // Currently defeat inlining by using a closure.
+ closure = () => 42;
+ bar = new A().foo;
+ }
+}
+
+@DontInline
+bar() {
+ // Make sure B's constructor is analyzed first by surrounding the
+ // body by two allocations.
+ new B();
+ // Currently defeat inlining by using a closure.
+ Expect.throws(() => new A.inline().foo + 42, (e) => e is NoSuchMethodError);
+ codegenLast();
+ new B();
+}
+
+@DontInline
+codegenLast() {
+ // This assignment currently defeats simple type inference, but not
+ // the optimistic inferrer.
+ new A().foo = new B().bar;
+ // Currently defeat inlining by using a closure.
+ new B().closure = () => 42;
+}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698