Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 164753002: Allow transformers in packages that are dev or override dependencies. (Closed)

Created:
6 years, 10 months ago by Bob Nystrom
Modified:
6 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow transformers in packages that are dev or override dependencies. BUG=https://code.google.com/p/dart/issues/detail?id=15841 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=32681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -15 lines) Patch
M sdk/lib/_internal/pub/lib/src/pubspec.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/pubspec_test.dart View 2 chunks +79 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
In the process of this, I discovered the pubspec tests for transformers were horribly broken. ...
6 years, 10 months ago (2014-02-13 21:18:27 UTC) #1
nweiz
lgtm
6 years, 10 months ago (2014-02-13 21:57:45 UTC) #2
Bob Nystrom
6 years, 10 months ago (2014-02-14 00:23:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698