Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3916)

Unified Diff: sdk/lib/_internal/pub/lib/src/pubspec.dart

Issue 164753002: Allow transformers in packages that are dev or override dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/test/pubspec_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/pubspec.dart
diff --git a/sdk/lib/_internal/pub/lib/src/pubspec.dart b/sdk/lib/_internal/pub/lib/src/pubspec.dart
index df9359a078c0bc5a8fb443a84b2bb2c599bc3d04..b44bb555b43702ba7efccfcba060803ca122a666 100644
--- a/sdk/lib/_internal/pub/lib/src/pubspec.dart
+++ b/sdk/lib/_internal/pub/lib/src/pubspec.dart
@@ -177,15 +177,19 @@ class Pubspec {
"$field.$library",
() => new TransformerId.parse(library, configuration));
- if (id.package != name && !id.isBuiltInTransformer &&
- !dependencies.any((ref) => ref.name == id.package)) {
- _error('"$field.$library" refers to a package that\'s not listed in '
- '"dependencies".');
+ if (id.package != name &&
+ !id.isBuiltInTransformer &&
+ !dependencies.any((ref) => ref.name == id.package) &&
+ !devDependencies.any((ref) => ref.name == id.package) &&
+ !dependencyOverrides.any((ref) => ref.name == id.package)) {
+ _error('"$field.$library" refers to a package that\'s not a '
+ 'dependency.');
}
return id;
}).toSet();
}).toList();
+
return _transformers;
}
List<Set<TransformerId>> _transformers;
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/test/pubspec_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698