Add expandable instances and lists to the vm service.

Add expandable instances and lists to the vm service.

Committed: https://code.google.com/p/dart/source/detail?r=32707

[Cutch, 2014-02-13 22:31:29]

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
(right):

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart:29:
app.requestManager.requestMap(url.substring(1)).then((map) {
Could you change requestMap to detect if the url starts with a # and skip it?

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html
(right):

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html:52:
ref['type'] == '@Array') }}">
Add a static method somewhere for these type checks and the others. e.g.:

bool isInstance(String type);
bool isList(String type);

[turnidge, 2014-02-14 17:36:47]

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
(right):

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart:29:
app.requestManager.requestMap(url.substring(1)).then((map) {
On 2014/02/13 22:31:29, Cutch wrote:
> Could you change requestMap to detect if the url starts with a # and skip it?

Done.  I find myself wondering if it would be better placed in request()
instead.  Unfortunately request is abstract which makes it awkward.

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html
(right):

https://codereview.chromium.org/164183003/diff/200001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html:52:
ref['type'] == '@Array') }}">
On 2014/02/13 22:31:29, Cutch wrote:
> Add a static method somewhere for these type checks and the others. e.g.:
> 
> bool isInstance(String type);
> bool isList(String type);

Done-ish.  Because we dwell in the land of polymer, statics don't work.  Added
instance methods to ObservatoryElement.

Do you remember how I was talking about coalescing some of these types in the vm
-- e.g. returning @List for @GrowableObjectArray and @Array, etc.  This would
make some of these compound tests shorter.

[turnidge, 2014-02-14 17:48:32]

Committed patchset #7 manually as r32707 (presubmit successful).