Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html

Issue 164183003: Add expandable instances and lists to the vm service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
index 0001a444b90e48142bf59e73b7a6b0ff17c72b1a..bd11972f5b749720923d5925269e90135a3d5cfd 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
@@ -6,6 +6,17 @@
</head>
<polymer-element name="stack-frame" extends="observatory-element">
<template>
+ <style>
+ .memberList {
+ margin-left: 3em;
+ border-spacing: 0;
+ border-collapse: collapse;
+ }
+ .member {
+ vertical-align: top;
+ padding: 0 1em;
+ }
+ </style>
<div class="row">
<div class="col-md-1"></div>
<div class="col-md-1">
@@ -18,18 +29,19 @@
<div class="col-md-1"></div>
</div>
- <template repeat="{{ v in frame['vars'] }}">
- <div class="row">
- <div class="col-md-3"></div>
- <div class="col-md-1">
- {{ v['name'] }}
- </div>
- <div class="col-md-6">
- <instance-ref app="{{ app }}" ref="{{ v['value'] }}"></instance-ref>
- </div>
- <div class="col-md-2"></div>
+ <div class="row">
+ <div class="col-md-3"></div>
+ <div class="col-md-9">
+ <table class="memberList">
+ <tr template repeat="{{ v in frame['vars'] }}">
+ <td class="member">{{ v['name']}}</td>
+ <td class="member">
+ <instance-ref app="{{ app }}" ref="{{ v['value'] }}"></instance-ref>
+ </td>
+ </tr>
+ </table>
</div>
- </template>
+ </div>
</template>
<script type="application/dart" src="stack_frame.dart"></script>
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698