Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 16409002: Fixing SelectElement.options, adding support for optgroup. (Closed)

Created:
7 years, 6 months ago by blois
Modified:
7 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing SelectElement.options, adding support for optgroup. BUG=8115 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=23652

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/html/selectelement_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 6 months ago (2013-06-05 01:16:56 UTC) #1
Emily Fortuna
lgtm
7 years, 6 months ago (2013-06-05 17:23:44 UTC) #2
blois
7 years, 6 months ago (2013-06-05 19:45:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698