Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate

Issue 16409002: Fixing SelectElement.options, adding support for optgroup. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/html/selectelement_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of $LIBRARYNAME; 5 part of $LIBRARYNAME;
6 6
7 $(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC { 7 $(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
8 $!MEMBERS 8 $!MEMBERS
9 9
10 // Override default options, since IE returns SelectElement itself and it 10 // Override default options, since IE returns SelectElement itself and it
11 // does not operate as a List. 11 // does not operate as a List.
12 List<OptionElement> get options { 12 List<OptionElement> get options {
13 var options = this.children.where((e) => e is OptionElement).toList(); 13 var options =
14 this.queryAll('option').where((e) => e is OptionElement).toList();
14 return new UnmodifiableListView(options); 15 return new UnmodifiableListView(options);
15 } 16 }
16 17
17 List<OptionElement> get selectedOptions { 18 List<OptionElement> get selectedOptions {
18 // IE does not change the selected flag for single-selection items. 19 // IE does not change the selected flag for single-selection items.
19 if (this.multiple) { 20 if (this.multiple) {
20 var options = this.options.where((o) => o.selected).toList(); 21 var options = this.options.where((o) => o.selected).toList();
21 return new UnmodifiableListView(options); 22 return new UnmodifiableListView(options);
22 } else { 23 } else {
23 return [this.options[this.selectedIndex]]; 24 return [this.options[this.selectedIndex]];
24 } 25 }
25 } 26 }
26 } 27 }
OLDNEW
« no previous file with comments | « tests/html/selectelement_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698