Issue 16308002: Fixes for Blink roll to r151189

Issue 16308002: Fixes for Blink roll to r151189 (Closed)

Created:
7 years, 6 months ago by vsm

Modified:
7 years, 6 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes for Blink roll to r151189 TBR=antonm Committed: https://code.google.com/p/dart/source/detail?r=23511

Patch Set 1 #

Total comments: 6

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -25 lines)			Patch
M	tools/dom/idl/dart/dart.idl	View	3 chunks	+19 lines, -4 lines	2 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/fremontcutbuilder.py	View	3 chunks	+3 lines, -4 lines	4 comments	Download
M	tools/dom/scripts/generator.py	View	4 chunks	+15 lines, -3 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	6 chunks	+7 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/idlparser.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Range.darttemplate	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Text.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://codereview.chromium.org/16308002/diff/1/tools/dom/idl/dart/dart.idl File tools/dom/idl/dart/dart.idl (right): https://codereview.chromium.org/16308002/diff/1/tools/dom/idl/dart/dart.idl#newcode301 tools/dom/idl/dart/dart.idl:301: interface Location { we probably should file a bug ...

7 years, 6 months ago (2013-06-03 09:02:19 UTC) #2

vsm

7 years, 6 months ago (2013-06-03 14:59:50 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/16308002/diff/1/tools/dom/idl/dart/dart.idl
File tools/dom/idl/dart/dart.idl (right):

https://codereview.chromium.org/16308002/diff/1/tools/dom/idl/dart/dart.idl#n...
tools/dom/idl/dart/dart.idl:301: interface Location {
Done - 11043

On 2013/06/03 09:02:19, Anton Muhin wrote:
> we probably should file a bug to remove those overrides and autogenerate the
> code.

https://codereview.chromium.org/16308002/diff/1/tools/dom/scripts/fremontcutb...
File tools/dom/scripts/fremontcutbuilder.py (right):

https://codereview.chromium.org/16308002/diff/1/tools/dom/scripts/fremontcutb...
tools/dom/scripts/fremontcutbuilder.py:31: 'ENABLE_ENCRYPTED_MEDIA_V2',
Yes, this one is still in the IDL.

On 2013/06/03 09:02:19, Anton Muhin wrote:
> why it moved here?  Do we have those defines somewhere?

https://codereview.chromium.org/16308002/diff/1/tools/dom/scripts/fremontcutb...
tools/dom/scripts/fremontcutbuilder.py:112: raise 'Halt'
On 2013/06/03 09:02:19, Anton Muhin wrote:
> oversight or by intent?

Sorry, temporary add to verify that there where no extraneous symbols.  Will
remove.

Expand Messages | Collapse Messages