Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/dom/scripts/fremontcutbuilder.py

Issue 16308002: Fixes for Blink roll to r151189 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/fremontcutbuilder.py
diff --git a/tools/dom/scripts/fremontcutbuilder.py b/tools/dom/scripts/fremontcutbuilder.py
index 16bf69a5e378547f5acf8d8b5f12f5068c86225a..74d840799e20dadf7e76dfea3ea52bf868020ee6 100755
--- a/tools/dom/scripts/fremontcutbuilder.py
+++ b/tools/dom/scripts/fremontcutbuilder.py
@@ -20,7 +20,6 @@ FEATURE_DISABLED = [
'ENABLE_BATTERY_STATUS',
'ENABLE_CSS_DEVICE_ADAPTATION',
'ENABLE_CUSTOM_SCHEME_HANDLER',
- 'ENABLE_ENCRYPTED_MEDIA_V2',
'ENABLE_MEDIA_CAPTURE', # Only enabled on Android.
'ENABLE_ORIENTATION_EVENTS', # Only enabled on Android.
'ENABLE_WEBVTT_REGIONS',
@@ -29,13 +28,11 @@ FEATURE_DISABLED = [
FEATURE_DEFINES = [
'ENABLE_CALENDAR_PICKER', # Not on Android
- 'ENABLE_DATALIST_ELEMENT', # Not on Android
- 'ENABLE_ENCRYPTED_MEDIA',
+ 'ENABLE_ENCRYPTED_MEDIA_V2',
Anton Muhin 2013/06/03 09:02:19 why it moved here? Do we have those defines somew
vsm 2013/06/03 14:59:50 Yes, this one is still in the IDL. On 2013/06/03
'ENABLE_INPUT_SPEECH', # Not on Android
'ENABLE_LEGACY_NOTIFICATIONS', # Not on Android
'ENABLE_NAVIGATOR_CONTENT_UTILS', # Not on Android
'ENABLE_NOTIFICATIONS', # Not on Android
- 'ENABLE_PAGE_POPUP', # Not on Android
'ENABLE_SVG',
'ENABLE_SVG_FONTS',
'ENABLE_WEB_AUDIO', # Not on Android
@@ -105,12 +102,14 @@ def build_database(idl_files, database_dir, feature_defines=None, parallel=False
_logger.warning('There are some unused conditionals %s' %
sorted(unused_conditionals))
_logger.warning('Please update fremontcutbuilder.py')
+ raise 'Halt'
unknown_conditionals = conditionals_met - known_conditionals
if unknown_conditionals:
_logger.warning('There are some unknown conditionals %s' %
sorted(unknown_conditionals))
_logger.warning('Please update fremontcutbuilder.py')
+ raise 'Halt'
Anton Muhin 2013/06/03 09:02:19 oversight or by intent?
vsm 2013/06/03 14:59:50 Sorry, temporary add to verify that there where no
db.Save()
return db

Powered by Google App Engine
This is Rietveld 408576698