Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 16295008: Fix type propagation bug by always narrowing types. (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type propagation bug by always narrowing types. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23577

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/type_propagation_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-03 14:18:06 UTC) #1
kasperl
LGTM.
7 years, 6 months ago (2013-06-04 05:36:23 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-04 06:52:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698