Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: tests/language/type_propagation_test.dart

Issue 16295008: Fix type propagation bug by always narrowing types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 // dart2js used to have an infinite loop in its type propagation
6 // algorithm due to types becoming broader instead of narrower.
7
8 import "package:expect/expect.dart";
9
10 class A {
11 resolveSend(node) {
12 if (node == null) {
13 return [new B()][0];
14 } else {
15 return [new B(), new A()][1];
16 }
17 }
18
19 visitSend(node) {
20 var target = resolveSend(node);
21
22 if (false) {
23 if (false) {
24 target = target.getter;
25 if (false) {
26 target = new Object();
27 }
28 }
29 }
30 return true ? target : null;
31 }
32 }
33
34 var a = 43;
35
36 class B {
37 var getter = a == 42 ? new A() : null;
38 }
39
40 main() {
41 Expect.isTrue(new A().visitSend(new A()) is A);
42 Expect.isTrue(new A().visitSend(null) is B);
43 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698