Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 16272004: Implements intrinsics for MIPS. (Closed)

Created:
7 years, 6 months ago by zra
Modified:
7 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implements intrinsics for MIPS. Also, adds the MADD, MADDU, MTLO, MTHI instructions to the MIPS simulator, assembler, and disassembler. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=23489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1614 lines, -39 lines) Patch
M runtime/vm/assembler_mips.h View 3 chunks +17 lines, -4 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 2 chunks +38 lines, -1 line 0 comments Download
M runtime/vm/assembler_mips_test.cc View 2 chunks +45 lines, -0 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_mips.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +1451 lines, -32 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 3 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 6 months ago (2013-05-31 20:43:07 UTC) #1
regis
LGTM
7 years, 6 months ago (2013-05-31 20:49:38 UTC) #2
zra
7 years, 6 months ago (2013-05-31 21:03:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698