Use 'new' in all the snapshot reallocation functions instead of realloc.

Fix for issue 1755.

Use 'new' in all the snapshot reallocation functions instead of realloc.
This would result in program termination when allocation fails and will
ensure that a NULL will not be returned.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23636

[Søren Gjesse, 2013-06-04 06:54:47]

dbc.

https://codereview.chromium.org/16271010/diff/1/runtime/vm/dart_api_message.cc
File runtime/vm/dart_api_message.cc (right):

https://codereview.chromium.org/16271010/diff/1/runtime/vm/dart_api_message.c...
runtime/vm/dart_api_message.cc:809: if (forward_id_ >= forward_list_length_) {
Not related to this change, but shouldn't this condition be

  forward_id_ == forward_list_length_

and then have 

  ASSERT(forward_id_ <= forward_list_length_)

before?

[srdjan, 2013-06-04 20:15:58]

LGTM

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h
File runtime/platform/utils.h (right):

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h#newc...
runtime/platform/utils.h:178: if ((old_len * sizeof(ElementType)) >=
greater only

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h#newc...
runtime/platform/utils.h:186: if (old_data != 0) {
!= NULL

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h#newc...
runtime/platform/utils.h:189: Utils::Minimum(old_len * sizeof(ElementType),
Just old_len

[siva, 2013-06-05 16:21:10]

Committed patchset #2 manually as r23636 (presubmit successful).

[siva, 2013-06-05 16:21:31]

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h
File runtime/platform/utils.h (right):

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h#newc...
runtime/platform/utils.h:178: if ((old_len * sizeof(ElementType)) >=
On 2013/06/04 20:15:58, srdjan wrote:
> greater only

Done.

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h#newc...
runtime/platform/utils.h:186: if (old_data != 0) {
On 2013/06/04 20:15:58, srdjan wrote:
> != NULL

Done.

https://codereview.chromium.org/16271010/diff/1/runtime/platform/utils.h#newc...
runtime/platform/utils.h:189: Utils::Minimum(old_len * sizeof(ElementType),
On 2013/06/04 20:15:58, srdjan wrote:
> Just old_len

Done.

https://codereview.chromium.org/16271010/diff/1/runtime/vm/dart_api_message.cc
File runtime/vm/dart_api_message.cc (right):

https://codereview.chromium.org/16271010/diff/1/runtime/vm/dart_api_message.c...
runtime/vm/dart_api_message.cc:809: if (forward_id_ >= forward_list_length_) {
On 2013/06/04 06:54:47, Søren Gjesse wrote:
> Not related to this change, but shouldn't this condition be
> 
>   forward_id_ == forward_list_length_
> 
> and then have 
> 
>   ASSERT(forward_id_ <= forward_list_length_)
> 
> before?

Done.