Use 'new' in all the snapshot reallocation functions instead of realloc.

runtime/platform/utils.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_UTILS_H_
 #define PLATFORM_UTILS_H_
 
 #include "platform/assert.h"
 #include "platform/globals.h"
 
@@ skipping 153 matching lines @@
   // without the risk of integer overflow.
   static inline bool RangeCheck(intptr_t offset,
                                 intptr_t count,
                                 intptr_t length) {
     return offset >= 0 &&
            count >= 0 &&
            length >= 0 &&
            count <= (length - offset);
   }
 
+  template <class ElementType>
+  static inline ElementType* Realloc(ElementType* old_data,
+                                     intptr_t old_len,
+                                     intptr_t new_len) {
+    if ((old_len * sizeof(ElementType)) >=

[srdjan, 2013/06/04 20:15:58]

greater only

[siva, 2013/06/05 16:21:31]

Done.

+        (new_len * sizeof(ElementType))) {
+      FATAL2("Realloc overflow: "
+             "'old_size'=%"Pd",'new_size'=%"Pd,
+             (old_len * sizeof(ElementType)),
+             (new_len * sizeof(ElementType)));
+    }
+    ElementType* new_data = new ElementType[new_len];
+    if (old_data != 0) {

[srdjan, 2013/06/04 20:15:58]

!= NULL

[siva, 2013/06/05 16:21:31]

Done.

+      memmove(reinterpret_cast<void*>(new_data),
+              reinterpret_cast<void*>(old_data),
+              Utils::Minimum(old_len * sizeof(ElementType),

[srdjan, 2013/06/04 20:15:58]

Just old_len

[siva, 2013/06/05 16:21:31]

Done.

+                             new_len * sizeof(ElementType)));
+      delete[] old_data;
+    }
+    return new_data;
+  }
+
   // Utility functions for converting values from host endianess to
   // big or little endian values.
   static uint16_t HostToBigEndian16(uint16_t host_value);
   static uint32_t HostToBigEndian32(uint32_t host_value);
   static uint64_t HostToBigEndian64(uint64_t host_value);
   static uint16_t HostToLittleEndian16(uint16_t host_value);
   static uint32_t HostToLittleEndian32(uint32_t host_value);
   static uint64_t HostToLittleEndian64(uint64_t host_value);
 };
 
 }  // namespace dart
 
 #if defined(TARGET_OS_ANDROID)
 #include "platform/utils_android.h"
 #elif defined(TARGET_OS_LINUX)
 #include "platform/utils_linux.h"
 #elif defined(TARGET_OS_MACOS)
 #include "platform/utils_macos.h"
 #elif defined(TARGET_OS_WINDOWS)
 #include "platform/utils_win.h"
 #else
 #error Unknown target os.
 #endif
 
 #endif  // PLATFORM_UTILS_H_