Don't change the case of cookie names and values

Don't change the case of cookie names and values

R=whesse@google.com
BUG=http://dartbug.com/11011

Committed: https://code.google.com/p/dart/source/detail?r=23582

[Bill Hesse, 2013-06-04 08:30:14]

lgtm

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_cook...
File tests/standalone/io/http_cookie_test.dart (right):

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_cook...
tests/standalone/io/http_cookie_test.dart:15: server.listen(
Should we show people how to indent closures less, by writing

server.listen((HttpRequest request) {
  // Collect the cookies in a map.

and similarly later down?

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_head...
File tests/standalone/io/http_headers_test.dart (right):

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_head...
tests/standalone/io/http_headers_test.dart:401: test("SID",
"sJdkjKSJD12343kjKj78");
While you are at it, are there any non-ascii values you can test, or are they
not valid?  Or are they tested elsewhere?

[Søren Gjesse, 2013-06-04 08:54:45]

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_cook...
File tests/standalone/io/http_cookie_test.dart (right):

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_cook...
tests/standalone/io/http_cookie_test.dart:15: server.listen(
On 2013/06/04 08:30:14, Bill Hesse wrote:
> Should we show people how to indent closures less, by writing
> 
> server.listen((HttpRequest request) {
>   // Collect the cookies in a map.
> 
> and similarly later down?

Done - I did not see any other places.

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_head...
File tests/standalone/io/http_headers_test.dart (right):

https://codereview.chromium.org/16256012/diff/1/tests/standalone/io/http_head...
tests/standalone/io/http_headers_test.dart:401: test("SID",
"sJdkjKSJD12343kjKj78");
On 2013/06/04 08:30:14, Bill Hesse wrote:
> While you are at it, are there any non-ascii values you can test, or are they
> not valid?  Or are they tested elsewhere?

We are definitely not trying to parse according to the spec which says:

 cookie-pair       = cookie-name "=" cookie-value
 cookie-name       = token
 cookie-value      = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )
 cookie-octet      = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
                       ; US-ASCII characters excluding CTLs,
                       ; whitespace DQUOTE, comma, semicolon,
                       ; and backslash

I will make a separate CL for this.

[Søren Gjesse, 2013-06-04 09:36:07]

Committed patchset #3 manually as r23582 (presubmit successful).